Component Apps: Add support for GeoJSON features #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncrawley
force-pushed
the
reactpy-fixes
branch
from
31f6226 to
ca89e4c
Compare
Contributor
Author
|
This one should be good to go. Merry Christmas! |
swainn
requested changes
Dec 30, 2025
Member
swainn
left a comment
swainn
left a comment
There was a problem hiding this comment.
Just a few debugging lines that need to be removed.
swainn
requested changes
Dec 30, 2025
swainn
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I received feedback from someone trying to learn Component Apps that they were not able to display GeoJSON on their map. Turns out that this was a shortcoming of Comopnent Apps that has now been addressed with this PR. A new Recipe was added to document how this is now done.
Changes Made to Code
OVERRIDESvariable that can override built-in library components with a custom component. In this case, thelib.ol.source.Vectorcomponent is overridden with the customlib.olmod.VectorSourcepackage that points to "tethys_apps/static/tethys_apps/js/ol-mods.js"Related PRs, Issues, and Discussions
Additional Notes
Quality Checks